Skip to content
This repository was archived by the owner on May 23, 2024. It is now read-only.

Conversation

@SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Nov 10, 2023

We can probably use the same documentation in the readme, so I will wait until I get some feedback, and then I will copy it to the readme.

@SergioGasquez SergioGasquez linked an issue Nov 10, 2023 that may be closed by this pull request
@SergioGasquez SergioGasquez marked this pull request as ready for review November 10, 2023 14:38
@bjoernQ
Copy link
Contributor

bjoernQ commented Nov 10, 2023

Looks good!

We can probably use the same documentation in the readme, so I will wait until I get some feedback, and then I will copy it to the readme.

Maybe we can avoid duplication with something like #![doc = include_str!("README.md")] and only have it as the README.md?

src/lib.rs Outdated
//! - Only one of these features can be enabled at a time.
//! - There is one feature for each supported communication method: `uart`,
//! `jtag-serial` and `rtt` `no-op`.
//! - Only one of these features can be enabled at a time.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to expand on this a bit. For example, by default, uart and jtag-serial both output to the same USB port on the esp32-s3, which can be somewhat confusing not only for newcomers.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, but this changes from chip to chip, devkit to devkit, any idea on how to document this. Any idea how to improve it?

@SergioGasquez
Copy link
Member Author

Maybe we can avoid duplication with something like #![doc = include_str!("README.md")] and only have it as the README.md?

TIL!

Does espflash support rtt, or is this a copy-paste bug?

Copy-paste error 😓

Moved the documentation the README and addressed some feedback

Copy link
Contributor

@bjoernQ bjoernQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SergioGasquez SergioGasquez merged commit 6d4f966 into esp-rs:main Nov 22, 2023
@SergioGasquez SergioGasquez deleted the feat/documentation branch November 22, 2023 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Document features

5 participants